Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.0.40 #64

Merged
merged 2 commits into from
Sep 15, 2024
Merged

Rc 1.0.40 #64

merged 2 commits into from
Sep 15, 2024

Conversation

semuadmin
Copy link
Contributor

pynmeagps Pull Request Template

Description

  1. Add area() helper method to calculate spherical area of bounding box.
  2. Sphinx documentation and docstrings enhanced to include global constants and decodes.
  3. socket_stream.SocketStream class renamed to socket_wrapper.SocketWrapper class for clarity.

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Add static test for area() method

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 15, 2024
@semuadmin semuadmin added this to the RC 1.0.40 milestone Sep 15, 2024
@semuadmin semuadmin self-assigned this Sep 15, 2024
@semuadmin semuadmin marked this pull request as draft September 15, 2024 09:23
@semuadmin semuadmin requested a review from a team September 15, 2024 09:23
@semuadmin semuadmin marked this pull request as ready for review September 15, 2024 09:24
@semuadmin semuadmin merged commit ca9b63a into master Sep 15, 2024
6 checks passed
@semuadmin semuadmin deleted the RC-1.0.40 branch September 15, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants