Fix infinite loop #342
Merged
Fix infinite loop #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linked was causing infinite loops on Debian 9 Linux.
…braries due to header included in OSVR-Core.
|
It would be preferable if we could just do a compiler test for that flag to see if it's supported, rather than just enabling it by force when we see "Linux", FWIW - in theory I know how to do this, given the documentation... |
|
I've used the compiler flag test before: include(CheckCXXCompilerFlag)
check_cxx_compiler_flag(-fext-numeric-literals SUPPORTS_EXT_NUMERIC_LITERALS)
if(SUPPORTS_EXT_NUMERIC_LITERALS)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fext-numeric-literals")
endif() |
…her than scoping it based on the operating system.
|
@rpavlik Kevin's fix seems to work on both Windows and Linux and I've added it to the pull request. It could easily be that this fixes the OSVR-Core issue by avoiding overlinking. |
russell-taylor
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was @russell-taylor 's work I just saw on gitk - is this ready to merge? Is it possibly related to OSVR/OSVR-Core#562 ?