Remove incorrect and un-necessary flipping of Y center of projection … #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for distortion correction when harnessing an OpenGL renderer to a Direct3D DirectMode renderer.
|
This fixes #323 |
… later so is not needed here, and the effects on the Y axis have to take into account when we flip Y. Just doing this single change in this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for distortion correction when harnessing an OpenGL renderer to a Direct3D DirectMode renderer.
This was scaling by the D factor, which it should not have been. It also did not need to be done at all; apparently the buffer flipping elsewhere in the system takes care of this properly without requiring flipping of the COP here.
Validated this using OpenGL and OpenGL/Direct3D displays, one on the monitor and one on a DK2.