fix(entity): fix bigdecimal to entity converter (#934)

sentioxyz · Aug 27, 2024 · 610dc33 · 610dc33
1 parent e5d2b58
commit 610dc33
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/sdk/src/store/convert.test.ts b/packages/sdk/src/store/convert.test.ts
@@ -25,6 +25,9 @@ describe('RichStruct converter tests', () => {
   })
 
   it('bigDecimal converter', () => {
+    testConverter(new BigDecimal('-1e100'), BigDecimalConverter)
+    testConverter(new BigDecimal('-0.006266950425962837'), BigDecimalConverter)
+    testConverter(new BigDecimal('1.006266950425962837'), BigDecimalConverter)
     testConverter(
       new BigDecimal('123456789012345678901234567890123456789012345678901234567890.123'),
       BigDecimalConverter

diff --git a/packages/sdk/src/store/convert.ts b/packages/sdk/src/store/convert.ts
@@ -232,12 +232,16 @@ export const BigDecimalConverter: ValueConverter<BigDecimal | undefined> = {
         nullValue: RichValue_NullValue.NULL_VALUE
       }
     }
-    const s = (value.c || []).join('')
+    const s = (value.c || [])
+      .map((v, idx) => {
+        return idx == 0 ? v.toString() : v.toString().padStart(14, '0')
+      })
+      .join('')
     const exp = -(s.length - (value.e ?? 0) - 1)
 
     return {
       bigdecimalValue: {
-        value: toBigInteger(BigInt(s)),
+        value: toBigInteger(BigInt(s) * BigInt(value.s ?? 1)),
         exp: exp
       }
     }