Skip to content

Commit

Permalink
feat: add configuration for noStrictOffsetReset (#1620)
Browse files Browse the repository at this point in the history
Introduce a new configuration option `noStrictOffsetReset` in the Snuba
replacer deployment template and values file. This allows users to
optionally disable strict offset reset behavior by setting
`noStrictOffsetReset` to true in the `values.yaml` file. This change
provides more flexibility in handling offset resets, which can be
useful in certain deployment scenarios where strict offset management
is not required or desired.
  • Loading branch information
pyama86 authored Dec 4, 2024
1 parent ac8143f commit 234552e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
3 changes: 3 additions & 0 deletions charts/sentry/templates/snuba/deployment-snuba-replacer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ spec:
{{- if .Values.snuba.replacer.queuedMinMessages }}
- "--queued-min-messages"
- "{{ .Values.snuba.replacer.queuedMinMessages }}"
{{- if .Values.snuba.replacer.noStrictOffsetReset }}
- "--no-strict-offset-reset"
{{- end }}
{{- end }}
ports:
- containerPort: {{ template "snuba.port" }}
Expand Down
1 change: 1 addition & 0 deletions charts/sentry/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1115,6 +1115,7 @@ snuba:
# queuedMinMessages: ""
# volumes: []
# volumeMounts: []
# noStrictOffsetReset: false

metricsConsumer:
enabled: true
Expand Down

0 comments on commit 234552e

Please sign in to comment.