Oc #155
Merged
Oc #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changing layer to unrealized potential biomass layer
updating from potential biomass to unrealized potential
12rambau
requested changes
Nov 22, 2022
There was a problem hiding this comment.
Multiple things here:
-
the asset
projects/ee-amcmahon/assets/seplan/seplan_layers/features/opportunity_cost_20221110that seems to be the more recent is not public could you change it's sharing parameters ? -
more a general comment, you mixed 2 PR in one which was very confusing. For the sake of clarity for the reviewers always follow these steps when making modifications from your fork:
- update your
mainby clicking on "sync fork" in the Github interface - create the new branch from
main(I always use the github interface as it has a good UI) - PR this new branch to the sepal-contrib
main
- update your
12rambau
requested changes
Nov 22, 2022
12rambau
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update opportunity cost layer
related to #154