Minor edits #105
Merged
Minor edits #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepandhaghighi
added
the
documentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #105 +/- ##
==========================================
+ Coverage 96.67% 96.81% +0.14%
==========================================
Files 2 2
Lines 210 219 +9
Branches 24 24
==========================================
+ Hits 203 212 +9
Misses 5 5
Partials 2 2 ☔ View full report in Codecov by Sentry. |
sadrasabouri
requested changes
Oct 21, 2024
nafas/functions.py
Outdated
| @@ -4,7 +4,8 @@ | |||
| import time | |||
| from nafas.params import NAFAS_DESCRIPTION, NAFAS_NOTICE, STANDARD_MENU, STANDARD_MENU_ORDER, STEP_MAP | |||
| from nafas.params import PROGRAMS, PROGRAM_DESCRIPTION, SOUND_MAP, STEP_TEMPLATE, CYCLE_TEMPLATE | |||
| from nafas.params import SOUND_WARNING_MESSAGE, EXIT_MESSAGE | |||
| from nafas.params import SOUND_WARNING_MESSAGE, EXIT_MESSAGE, BAD_INPUT_MESSAGE, PROGRAM_END_MESSAGE | |||
| from nafas.params import MINUTES_TEMPLATE, SECONDS_TEMPLATE, PROGRAM_TIME_TEMPLATE, MENU_TEMPLATE_1, MENU_TEMPLATE_2 | |||
There was a problem hiding this comment.
Move the import of MENU_TEMPLATE_1 and MENU_TEMPLATE_2 to the next line. It's too long now.
sadrasabouri
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
params.pyAUTHORS.mdupdatedAny other comments?