Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playsound -> nava #79

Merged
merged 11 commits into from
Jul 2, 2024
Merged

playsound -> nava #79

merged 11 commits into from
Jul 2, 2024

Conversation

sadrasabouri
Copy link
Collaborator

Reference Issues/PRs

#49

What does this implement/fix? Explain your changes.

Due to the deprecation of playsound in Python, we made a sound library (nava) and switched to it 😄

@sadrasabouri sadrasabouri self-assigned this Feb 4, 2024
@sadrasabouri sadrasabouri added the enhancement New feature or request label Feb 4, 2024
@sadrasabouri sadrasabouri added this to the nafas v0.7 milestone Feb 4, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (4eacae1) to head (7ff3e40).

Current head 7ff3e40 differs from pull request most recent head 37de2e9

Please upload reports for the commit 37de2e9 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #79      +/-   ##
==========================================
- Coverage   98.07%   98.00%   -0.06%     
==========================================
  Files           2        2              
  Lines         207      200       -7     
  Branches       22       21       -1     
==========================================
- Hits          203      196       -7     
  Misses          3        3              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadrasabouri sadrasabouri marked this pull request as ready for review February 19, 2024 08:07
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@sepandhaghighi sepandhaghighi merged commit 9d1ddd5 into dev Jul 2, 2024
39 checks passed
@sepandhaghighi sepandhaghighi deleted the playsound-nava branch July 2, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants