[INFRA] Better LTO handling #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seqan-actions
added
lint
|
Documentation preview available at https://docs.seqan.de/preview/seqan/hibf/244 |
eseiler
force-pushed
the
infra/better_lto
branch
from
7c45f3d
to
14ed91e
Compare
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 51 51
Lines 1951 1951
Branches 5 5
=======================================
Hits 1943 1943
Misses 8 8 ☔ View full report in Codecov by Sentry. |
eseiler
force-pushed
the
infra/better_lto
branch
from
8f21b20
to
e12319a
Compare
seqan-actions
added
lint
Force projects that include HIBF to enable CMAKE_INTERPROCEDURAL_OPTIMIZATION. CMake does not only detect the compiler flags, but also chooses programs that support the lto-plugin (ar, ranlib, ...). This means that exporting the CXX_FLAGS is not enough, because linking might fail due to the wrong programs being chosen.
eseiler
force-pushed
the
infra/better_lto
branch
from
303452a
to
c178907
Compare
seqan-actions
added
lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force projects that include HIBF to enable CMAKE_INTERPROCEDURAL_OPTIMIZATION.
CMake does not only detect the compiler flags, but also chooses programs that support the lto-plugin (ar, ranlib, ...).
This means that exporting the CXX_FLAGS is not enough, because linking might fail due to the wrong programs being chosen.