[MISC] Improve bulk_contains performance #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 91.10% 91.11%
=======================================
Files 37 37
Lines 1226 1227 +1
=======================================
+ Hits 1117 1118 +1
Misses 109 109
☔ View full report in Codecov by Sentry. |
seqan-actions
added
lint
seqan-actions
added
lint
seqan-actions
added
lint
seqan-actions
added
lint
Depending on number of bins, around 2x to 6x
…building with SSE/AVX
smehringer
approved these changes
Aug 24, 2023
Comment on lines
+711
to
+714
| #ifndef NDEBUG | ||
| assert(bin_words != 0u); | ||
| assert(hash_funs != 0u); | ||
| #else |
There was a problem hiding this comment.
auch wegen der Auto-vectorisierung? Denn eigentlich sollten asserts im release mode ja sowieso wegcompiliert werden oder?
There was a problem hiding this comment.
I want to actually assert in Debug mode, and not just declare it as UB. No idea what happens (guaranteed) when I have both __builtin_unreachable() and an assert :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things that will also help:
Things that might help:
bulk_contains, especially in conjunction withbulk_countThe changes rely on auto-vectorization and might be done more elegantly by hand.
192is faster than before, but relatively slow.128and256can be done in one step with AVX2, but192requires two.192is around 30% slower than128or256.bulk_contains benchmark with 1GiB data, throughput in hashes/sec: