-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Try to clarify sha256 explanation #490
Open
ewels
wants to merge
3
commits into
master
Choose a base branch
from
sha-docs-tweaks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -61,10 +61,10 @@ If an access token isn't provided, the following rate limits apply: | |||||||||
The Wave does not support the use of sha256 digest in the image name, e.g. `ubuntu@sha256:3235...ce8f`, when using | ||||||||||
the augmentation process to extend container images. | ||||||||||
|
||||||||||
In order to reference a container via sha256 digest in the image name with Wave you will need to *freeze* image mode | ||||||||||
that will force the creation of a new container image using the container you have specified as base image. | ||||||||||
In order to reference a container via this sha256 digest tag, you will need to use the _freeze_ image mode. | ||||||||||
This will force the creation of a new container image, using the container you have specified as base image. | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
In your pipeline configuration, ensure that you specify the following settings: | ||||||||||
For example, in your pipeline configuration you could specify the following settings: | ||||||||||
|
||||||||||
```groovy | ||||||||||
wave.enabled = true | ||||||||||
|
@@ -73,6 +73,12 @@ wave.strategy = ['dockerfile'] | |||||||||
wave.build.repository = 'docker.io/<user>/<repository>' | ||||||||||
``` | ||||||||||
|
||||||||||
This would build a new image, push it to docker.io and return a URI with the following structure: | ||||||||||
|
||||||||||
``` | ||||||||||
docker.io/<user>/<repository>:<image>--<hash> | ||||||||||
``` | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
|
||||||||||
## Tutorials | ||||||||||
|
||||||||||
### Authenticate private repositories | ||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.