Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rosserial_test and add rosserial_server #89

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Remove rosserial_test and add rosserial_server #89

merged 1 commit into from
Aug 22, 2024

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Aug 22, 2024

rosserial_test is not released to rosdistro.
Add rosserial_server to run rosserial_test.

@at-wat at-wat self-assigned this Aug 22, 2024
@at-wat at-wat requested a review from f-fl0 August 22, 2024 02:52
f-fl0
f-fl0 reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@f-fl0 f-fl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add rosserial_server to run rosserial_test.

I might be wrong but I cannot find the dependency to rosserial_test in rosserial_server so I'm not sure why adding rosserial_server implies running the tests from rosserial_test.

@at-wat
Copy link
Member Author

at-wat commented Aug 22, 2024

@f-fl0 I'm manually adding rosserial_test to aports-ros-experimental and rosseria_test has dependency to rosserial_server which is currently not built
https://github.com/ros-drivers/rosserial/blob/c169ae2173dcfda7cee567d64beae45198459400/rosserial_test/package.xml#L21

@at-wat at-wat merged commit 3871a6f into master Aug 22, 2024
3 checks passed
@at-wat at-wat deleted the remove-rosserial-test-and-add-server branch August 22, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-fl0 f-fl0 f-fl0 approved these changes

Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@at-wat @f-fl0