Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Dockerize databases to speed-up local testing #502

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jsau-
Copy link

@jsau- jsau- commented Feb 27, 2021

Adds Docker containers for supported database types to speed up testing.

Relates to: #478

Outstanding issues: On boot the mssql container complains about errors, seems that the model script might have problems?

Previously we mixed 'Northwind' and 'northwind' across the mysql migrations, causing failures on execution. Changed to consistent lowercase
@jsau- jsau- marked this pull request as draft February 27, 2021 20:04
@steveschmitt
Copy link
Collaborator

@jsau- I updated the mssql scripts in sample/dbscripts (in the master branch). See if those changes help you.

@jsau-
Copy link
Author

jsau- commented Mar 3, 2021

Awesome, thanks, I just took a quick look and I'm still getting the same error. I should have some time this weekend to properly look at it - it'll likely be something wrong with what I'm doing; I ran everything from master manually in an mssql shell and they all seemed to execute fine without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants