Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TypeScript model generation - use declare on all class fields and methods #628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duki994
Copy link

@duki994 duki994 commented Dec 1, 2022

Summary

Description

All model classes were generated without declare keyword which made TypeScript to shadow Sequelize generated models.

Future plans

Create a PR with changes to code to use new InferAtributes and InferCreationAttributes

@ephys ephys self-requested a review January 11, 2023 16:09
@jmfirth-arkane
Copy link

We would like to see this merged as it is currently causing issues in our TypeScript/ES2022 target codebase. What needs to be done to see this included?

@duki994
Copy link
Author

duki994 commented Jul 11, 2024

We would like to see this merged as it is currently causing issues in our TypeScript/ES2022 target codebase. What needs to be done to see this included?

Haven't worked in JS/TS ecosystem for a while.

I'll commit some of my OSS time to fix the issues as this modification had so many use cases across all TS projects I ever did.

@csimpsonprepsportswear
Copy link

I too would like this merged as the lack of declare on TypeScript fields is causing problems using the models generated by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants