-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating runner to use database versions and CI comparable to v7 #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but there is still the issue that tests for v7 try to run on database versions that are unsupported. For example the postgres ones run on 9.5 and 10, but according to https://sequelize.org/releases/ only 11 and up is supported.
Good point! We've updated files surrounding that in the sequelize repo for usage in the CI, but haven't updated that here. That shouldn't be why some of these tests are failing but I'll look into that later. |
Update; I think it is indeed the postgres and MySQL versions that cause this to break. I'll need to update this with the files from the core repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is too involved with databases and CI tools I'm not familiar with for me to review.
Pretty great to see an update in this repository |
Good idea! I'll look into that for the next PR |
Fixes sequelize/sequelize#16434
This PR overhauls this repo once again.
In a future PR we should add DB2 support, this PR is already too large as it is.
And we should maybe consider deprecating this repo and updating SSCCE functionality in v6/main branches of the core repo and add a GitHub action that automatically tags a PR that (only) updates the SSCCE. That way we can easily filter out the SSCCE PRs and we don't have to maintain two separate versions.