Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup leftover dbg from clamping timeouts #216

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

sirhcel
Copy link
Contributor

@sirhcel sirhcel commented Sep 5, 2024

We should not generate any output to stdout or stderr unconditionally. Especially as a library.

This PR brings just the cleanup for #215 to buy some time for the discussion there.

Using this macro should be a temporary measure and not generate output
from production code or tests. It cold be allowed for individual
examples, if needed.
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@eldruin eldruin merged commit 23b80b3 into serialport:main Sep 19, 2024
30 checks passed
@sirhcel sirhcel mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants