-
Notifications
You must be signed in to change notification settings - Fork 197
FailureCallback does not expose the Exception that caused the failure #381
Comments
The purpose is to somehow store the lost events to some other location, not directly handle the underlying exception. That exception will be the same for all the event that suffered this problem while being stored to Elasticsearch. Like a connection exception. |
There can be multiple causes on why the logs are not being stored, how would someone fix the issue if there is no error data? |
+1 The logevent even already has an "exeption" property, but it does not get populated. |
+1 |
My reason for wanting this is to be able to filter out the failed events which needs to be handled. Like mapper_parsing_exception which I would like to escalate but then ignore stuff like connection errors |
@mivano Is there a chance to add this feature? |
Looks like something useful based on the feedback. Care for a PR? |
Hello everybody. I'm in shock! Why is not this problem resolved yet? Do not you have two years enough to fix it? |
I have merged the mentioned PR, so that should give you a beta package at least. Regarding the tone of your message; as far as I know, you are not paying for support, and this is part of the deal of using open-source components. See all the reasoning here: #486 So sorry that you are shocked that this took two years, but do remember this is not my full-time job to maintain an open source framework and do the unpaid tasks for everybody that wants something... |
Does this issue relate to a new feature or an existing bug?
Please describe the current behavior?
FailureCallback
doesn't expose theException
causing the failurePlease describe the expected behavior?
FailureCallback
could expose theException
that caused the failureI came across this myself, and then saw a similar question on Stackoverflow. Is there any appetite for merging something that would expose the exception, for example, something like this?
The text was updated successfully, but these errors were encountered: