This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Added original exception to FailureCallback action #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this merged, I need exactly this to investigate why I get elastic failures every now and then :) |
| @@ -242,7 +242,7 @@ private void HandleResponse(IEnumerable<LogEvent> events, DynamicResponse result | |||
| // Send to a failure callback | |||
| try | |||
| { | |||
| _state.Options.FailureCallback(e); | |||
| _state.Options.FailureCallback(e, null); | |||
There was a problem hiding this comment.
We should find a way to raise a meaningful exception here as well. I did a test with 403 response from elastic and ended up here but the null doesn't tell anything to the higher-up code.
This gives me usable information to act upon (copied selflog from line 216):
_state.Options.FailureCallback(e, new Exception(string.Format("Failed to store event with template '{0}' into Elasticsearch. Elasticsearch reports for index {1} the following: {2}",
e.MessageTemplate,
action["_index"],
_state.Serialize(action["error"]))));
|
Is this ever going to get merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
#381
Does this PR introduce a breaking change?
Yes
Please check if the PR fulfills these requirements
Other information:
At first I thought it would be nice to populate the Exception in the Logevent but unfortunately it had no setter. So had to be a breaking change instead