Support relative dates and non-numeric pids #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 92.17% 92.58% +0.40%
==========================================
Files 8 8
Lines 409 418 +9
==========================================
+ Hits 377 387 +10
+ Misses 32 31 -1 ☔ View full report in Codecov by Sentry. |
hillalex
commented
Oct 15, 2024
| obs_id = seq_len(.N), | ||
| t_since_last_exp = as.integer(day - last_exp_day, units = "days"))] | ||
| if (!("censored" %in% colnames(private$data))) { | ||
| private$data$censored <- 0 |
There was a problem hiding this comment.
also make censored an optional column (default to all uncensored)
hillalex
changed the title
|
Closes #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should accomodate data sets that have a relative date/day/time column (i.e. natural numbers) rather than absolute dates. Also support non-numeric pids.
Changes:
time_typeargument in the main class initializer. This was used inconsistently, and seems a bit confusingcensoredan optional input column (default to all observations uncensored)