-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shiny app for diagnostics #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hillalex
force-pushed
the
shiny
branch
4 times, most recently
from
November 1, 2024 10:51
3dd5afb
to
c2c9da0
Compare
hillalex
force-pushed
the
shiny
branch
2 times, most recently
from
November 4, 2024 16:43
8e4b7fd
to
c90f627
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
===========================================
- Coverage 94.53% 76.32% -18.21%
===========================================
Files 9 11 +2
Lines 567 718 +151
===========================================
+ Hits 536 548 +12
- Misses 31 170 +139 ☔ View full report in Codecov by Sentry. |
hillalex
force-pushed
the
shiny
branch
2 times, most recently
from
November 5, 2024 16:17
6b458f2
to
54b9552
Compare
hillalex
force-pushed
the
i28
branch
2 times, most recently
from
November 11, 2024 12:16
af14330
to
1004715
Compare
only use log scale in plot if data is not already logged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function
biokinetics$inspect
which opens a shiny app and allows the user to inspect data and priors before fitting. Will add the post-fitting diagnostic plots in a future PR.It also adds a vignette detailing the input data plots available. Again, will add info about output plots in the next PR.
To test out the shiny app:
I haven't really attempted to write tests for the shiny logic. It's quite a simple app and the tests are a massive pain to write and run, so I don't think the time involved is worth it right now. So would be very useful if you could have a play around with it manually to confirm working as expected!