Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiny app for diagnostics #26

Merged
merged 9 commits into from
Dec 2, 2024
Merged

shiny app for diagnostics #26

merged 9 commits into from
Dec 2, 2024

Conversation

hillalex
Copy link
Member

@hillalex hillalex commented Oct 29, 2024

This PR adds a function biokinetics$inspect which opens a shiny app and allows the user to inspect data and priors before fitting. Will add the post-fitting diagnostic plots in a future PR.

It also adds a vignette detailing the input data plots available. Again, will add info about output plots in the next PR.

To test out the shiny app:

devtools::load_all()
data <- data.table::fread(system.file("delta_full.rds", package = "epikinetics"))
mod <- biokinetics$new(data = data, covariate_formula = ~0 + infection_history)
mod$inspect()

I haven't really attempted to write tests for the shiny logic. It's quite a simple app and the tests are a massive pain to write and run, so I don't think the time involved is worth it right now. So would be very useful if you could have a play around with it manually to confirm working as expected!

@hillalex hillalex force-pushed the shiny branch 4 times, most recently from 3dd5afb to c2c9da0 Compare November 1, 2024 10:51
@hillalex hillalex changed the base branch from plotting to main November 1, 2024 10:52
@hillalex hillalex force-pushed the shiny branch 2 times, most recently from 8e4b7fd to c90f627 Compare November 4, 2024 16:43
@hillalex hillalex changed the base branch from main to i28 November 4, 2024 16:43
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 10.89744% with 139 lines in your changes missing coverage. Please review.

Project coverage is 76.32%. Comparing base (45dab7e) to head (5d96c70).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
R/inspect-model.R 0.00% 121 Missing ⚠️
R/shiny-utils.R 41.37% 17 Missing ⚠️
R/biokinetics.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
- Coverage   94.53%   76.32%   -18.21%     
===========================================
  Files           9       11        +2     
  Lines         567      718      +151     
===========================================
+ Hits          536      548       +12     
- Misses         31      170      +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex force-pushed the shiny branch 2 times, most recently from 6b458f2 to 54b9552 Compare November 5, 2024 16:17
@hillalex hillalex force-pushed the i28 branch 2 times, most recently from af14330 to 1004715 Compare November 11, 2024 12:16
@hillalex hillalex changed the base branch from i28 to main November 19, 2024 13:45
@hillalex hillalex changed the title Shiny shiny app for diagnostics Nov 19, 2024
@hillalex hillalex marked this pull request as ready for review November 20, 2024 13:06
@hillalex hillalex requested review from dchodge and thimotei November 20, 2024 14:40
@hillalex hillalex merged commit cf7a1e2 into main Dec 2, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant