Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor priors #31

Merged
merged 3 commits into from
Nov 15, 2024
Merged

refactor priors #31

merged 3 commits into from
Nov 15, 2024

Conversation

hillalex
Copy link
Member

@hillalex hillalex commented Nov 14, 2024

  • no need for a base class of guassian priors
  • change weird function signature from 2 vectors to just named arguments

(this will help with the interactive shiny app, but also just make sense, the current interface is weird for no reason)

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (edeefbb) to head (85979fc).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   93.47%   93.54%   +0.07%     
==========================================
  Files           9        9              
  Lines         506      496      -10     
==========================================
- Hits          473      464       -9     
+ Misses         33       32       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hillalex hillalex marked this pull request as ready for review November 15, 2024 11:56
@hillalex hillalex merged commit 1c2c50a into main Nov 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant