-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Update some versions #243
Conversation
bafeaa2
to
48ec51e
Compare
Problem: lts-15.11 specified in stack.yaml is rather old. Solution: update to the latest one.
Problem: in hashable-1.4 `Eq` is a superclass of `Hashable`, it causes warnings in some code. Solution: use CPP to check `hashable` version and replace `(Eq a, Hashable a)` constraint with just `Hashable a` for new version.
Problem: it's hard to keep "Projects that use Universum" section up-to-date. Now it mostly contains deprecated projects. Solution: delete it since it's not really useful and rather confusing (due to not being promptly updated).
Problem: IncoherentInstances extensions is deprecated, it's recommended to use per-instance pragmas instead. Solution: do not enable this extension, specify per-instance pragmas where necessary.
Problem: for some reason ghc-9.0.1 is unable to compile benchmark code which is successfully compiled by older versions of ghc. Solution: provide explicit type annotations to help ghc compile this code, it appeared to be sufficient.
c1c6837
to
f0df61a
Compare
@Martoon-00 AFAIU you are the author of |
That's true that I believe this is a regression in GHC. super :: [()] -> Bool
super = null ... asFun (: [])
asFun :: (a -> b) -> a -> b
asFun = id This code works fine, while removing While this breakage is sad and we have little guarantees on how Does it make sense? Perhaps it would be nice to create a separate issue in this repository for tracking this, and assign it to someone to make sure there is someone responsible over it to have some progress over time. |
I've asked about it in our The way I understand it is that in general such a breakage may be not a compiler bug because And also I am a bit worried about this:
Anyway, you are right that we need a separate issue for it and I think it doesn't block this PR, so I'll proceed to merging it. |
See #249. |
Description
Just some casual maintenance.
Related issues(s)
None
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
reference this issue. See also auto linking on
github.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
and
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit description
If necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.