Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moss: Ignore SIGINT during blit #329

Merged
merged 1 commit into from
Aug 16, 2024
Merged

moss: Ignore SIGINT during blit #329

merged 1 commit into from
Aug 16, 2024

Conversation

tarkah
Copy link
Collaborator

@tarkah tarkah commented Aug 16, 2024 •
edited
Loading

Partially handles #310

@tarkah tarkah requested review from ikeycode and ermo as code owners August 16, 2024 20:16
ikeycode
ikeycode approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@ikeycode ikeycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging for expediency sake but ofc will test locally now =)

@ikeycode ikeycode merged commit 4966f0f into main Aug 16, 2024
1 of 2 checks passed
@ikeycode ikeycode deleted the feat/ignore-signals-during-blit branch August 16, 2024 20:53
@tarkah
Copy link
Collaborator Author

tarkah commented Aug 16, 2024

I added a sleep(10s) after the caller of new_state to test that Ctrl-c doesn't kill during blit, but it does after the blit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeycode ikeycode ikeycode approved these changes

@ermo ermo Awaiting requested review from ermo ermo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarkah @ikeycode