core-text: Implement CTRunGetTypographicBounds. #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compile error here seems genuine. Import added in #517 is missing in this PR. |
vorporeal
force-pushed
the
vorporeal/CTRunGetTypographicBounds
branch
from
9c4dc9b to
9b24547
Compare
|
Ack; fixed and pushed an updated commit. Sorry about that - didn't have my macOS machine available at the time (was on Linux) so couldn't actually compile locally. |
|
@nicoburns friendly ping :) |
|
Another gentle ping here. :) |
jrmuizel
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split out from #517.