Remove core_graphics::private::CGSRegion
#700
Open
+0
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a private API on macOS. This code was added for use in `servo-glutin` and was not used outside of that as far as I know (by doing various code searches). Fixes servo#656.
|
If there is someone using this, they can take the code that used to be here and use it within their own codebase rather than us maintaining it. |
jdm
approved these changes
Aug 12, 2024
|
Perhaps we can do a quick turnaround here and release the 0.11 series in order to not block the pending PRs that should be merged? |
|
I want to go through more of the backlog of things to make sure that we're not missing things. There's at least a couple that should land! Taking a couple of days for that seems fine... Propagating all of this stuff into the broader ecosystem is going to be some serious work. |
mrobinson
added
the
major release
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a private API on macOS. This code was added for use in
servo-glutinand was not used outside of that as far as I know (by doing various code searches).Fixes #656.