fix(test): Fixed improper mocking of ioredis resources in unit tests #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… index which to use for single-instance configurations with cluster mode disabled
… and added details for configuring redlock to use a specific DB index for single instance with cluster mode disabled
…pec.ts to system.spec.ts to distinguish unit from system tests. Updated package.json accordingly. Added system tests to cover use cases for configuring a specific DB number. Added unit test coverage for Redlock settings and acquire, extend, and release methods.
…ttempting to connect to a redis host when instantiating an object of the Redis class
djMax
approved these changes
Jun 15, 2024
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered after I woke up and saw PR #10 was approved and merged, that the output of the unit test runs included
iorediserrors where it was attempting to connect to a redis host. I had improperly mocked only the functions I was testing in theRedisobject and not all resources fromioredis. This fix resolves the issue and the tests still behave as desired.unit.spec.tsto properly mock allioredisresources using vitest.