Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase viewangles roll limit to 180 #83

Closed
wants to merge 2 commits into from

Conversation

fabiolimamp
Copy link

Quake historically puts a limit of 50 degrees for the player's v_angle Z component.

This limit seems arbitrary however, since the Z roll angle "sticks" and must be managed by the mod either way, and nothing breaks with it increased.

@sezero
Copy link
Owner

sezero commented Nov 26, 2023

@ericwa, @andrei-drexler: comments, objections?

@andrei-drexler
Copy link
Contributor

This looks like a sensible change, but maybe it should be controlled by a cvar (cl_maxroll, defaulting to 180)? That would make it consistent with the pitch limits (cl_minpitch/cl_maxpitch) and it would allow purists to go back to the original behavior by setting it to 50.

@fabiolimamp
Copy link
Author

Per @andrei-drexler suggestion, updated the PR with a new cl_maxroll cvar defaulted to 180.

@andrei-drexler
Copy link
Contributor

@sezero since you're on a roll, maybe merge this one as well? :)

@sezero
Copy link
Owner

sezero commented Sep 30, 2024

@sezero since you're on a roll,

Am I? :))

maybe merge this one as well?

You did not do this in ironwail. And I don't like these kinds
of arbitrary stuff very much. How does other engines compare?

@sezero
Copy link
Owner

sezero commented Sep 30, 2024

OK, looked at joequake, it too limits it with +/-50, same as qs and iw.
(Darkplaces does use +/-180 though.)

So, I am not 100% sure that we need this patch.

@sezero
Copy link
Owner

sezero commented Sep 30, 2024

OK, decided not applying this one for now.

@sezero sezero closed this Sep 30, 2024
@andrei-drexler
Copy link
Contributor

Removing the roll limit is likely useful for this kind of trick: https://x.com/fabiolimamp/status/1524507610472398848 (in order to have a smooth transition no matter the initial player angle). I haven't merged it in IW because modders that care about QS support (the vast majority, I think) wouldn't be able to rely on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants