Fixed inconsistent sidebar styles bug #10
Conversation
|
Will not merge. This fix introduces new bugs in existing styles and javascript. See: |
|
Please reference the issue you are closing either in the body of the pull request or directly inside your commit message. |
|
Fixes #1. Changed ".sidebar_item"/".sidebar_body" to ".sidebar-item"/".sidebar-body" in existing styles and javascript. |
| @@ -22,7 +22,7 @@ | |||
| padding: 45px; | |||
| border: 1px solid #ccc; | |||
| } | |||
| .sidebar_item { | |||
| .sidebar-item { | |||
There was a problem hiding this comment.
Please explain how modifying sidebar_style to sidebar-style is relevant to original issue.
|
Changing the archives class to sidebar-item from sidebar_item fixed the styles bug because sidebar-item had the required styles. |
| @@ -1,4 +1,4 @@ | |||
| <li id="sidebar_<%= sidebar.id %>" class="sidebar_item" data-sortable="sidebar_<%= sidebar.id %>" > | |||
| <li id="sidebar_<%= sidebar.id %>" class="sidebar-item" data-sortable="sidebar_<%= sidebar.id %>" > | |||
There was a problem hiding this comment.
Will not merge.
This fix introduces new bugs in existing styles and javascript.
See:
app/assets/stylesheets/sidebar_admin.css.scss#L25
app/assets/javascripts/sidebar.js#L31
tgaff
added
Good To Merge - great job!
and removed
breaks existing code
please revise
labels
|
⭐ |
No description provided.