-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Month sorting #30
Closed
Closed
Month sorting #30
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b6f70fc
Added psych to gemfile
jroers 5f8c43f
Changed font family for titles to be monospace, changed li tags to be…
jroers 2b8fb29
Removed sanity check with months hash
jroers d530582
Merge pull request #1 from jroers/fix_sidebar_styles
jroers 0c29dc6
January was being interpreted as the year prior. No idea why. Added l…
jroers c246835
Modified the +1 after month[:month] - this caused a redirect to the w…
jroers bc70c68
Months.to_i doesn't need mod 12. This was producing issue #2, as 12%1…
jroers 38e4842
why is this still here.
jroers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
lib/archives_sidebar/app/views/archives_sidebar/_content.html.erb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
<% unless sidebar.archives.blank? %> | ||
<h3 class="sidebar_title"><%= sidebar.title %></h3> | ||
<div class="sidebar_body"> | ||
<ul id="archives"> | ||
<h3 class="sidebar-title"><%= sidebar.title %></h3> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How is this html change relevant to issue #2? |
||
<div class="sidebar-body"> | ||
<ul> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are you sure this ID isn't used by some other code ? (JS, RSpec, etc) |
||
<% sidebar.archives.each do |month| %> | ||
<% counter = sidebar.show_count ? "<em>(#{month[:article_count]})</em>" : "" %> | ||
<li> | ||
<%= link_to"#{month[:name]} #{counter}".html_safe, articles_by_month_path( month[:year], "%02i" % (month[:month]+1) ) %> | ||
<%= link_to"#{month[:name]} #{counter}".html_safe, articles_by_month_path( month[:year], "%02i" % (month[:month]) ) %> | ||
</li> | ||
<% end %> | ||
</ul> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to add this to the gemfile?