-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge whole history of tokio-postgres-rustls as a crate #962
base: master
Are you sure you want to change the base?
Conversation
Thanks for the hint, @jbg.
FYI that repo is only archived because it moved to SourceHut. The crate is still developed and maintained. That being said, I'm happy if it can come under the rust-postgres umbrella. |
@jbg thank you so much! I wasn't sure what has happened to it, and some of us got really concerned when we saw that your repo was archived without any notes, while crates.io still pointed to it. Could you maybe unarchive it, put some big notification at the top with the links to the new location, and re-archive it? I am not familiar with the sourcehut, and I tried to find it there, but it didn't come up with any results. I am all for collaborative software development -- we tend to support software until our interest runs out, so ideally there should be a community behind each project rather than a single person - to prevent any kind of disaster or lack of interest from ruining an amazing project. I am not sure what @sfackler 's plans are for this project - I really hope we can all work on it together, perhaps starting an organization too? Regardless, you have done a great job maintaining it, so I wouldn't want to take it away from you, but please consider keeping it on github so that all other FOSS devs can easily participate. Thanks! |
There is a link at the top of the Github repo (at the right on desktop) to the Sourcehut repo. I may just move back to Github given that hosting elsewhere causes this confusion 😬 |
Sorry for the delay - if @jbg's happy maintaining it externally then I think it'd probably be best to keep things as-is. |
I'm ok either way, but one thing to note: we urgently need to implement all the tls compatibility with rustls - the upstream team seems to not want to have an easy path for us to upgrade from openssl to rustls, and thus we would have to do a considerable implementation of everything related to I think it would be best to implement this type of functionality in this project for higher visibility -- keeping postgresql-related things together is easier than trying to hunt for individual pieces. Of course if @jbg is ok with this transition? |
@nyurik Can you clarify what functionality you are talking about when you say "all the tls compatibility with rustls"? Any kind of verification (or lack thereof) that you can implement with |
Ah, I see you already have. Linking to jbg/tokio-postgres-rustls#11 here for context and will continue the discussion there. |
Given the lack of response to any of
|
I really think that |
I've made a |
This code does not have any significant changes from the original (archived) code at https://github.com/jbg/tokio-postgres-rustls
Changes:
/postgres-rustls
direnv_logger
dev dependency to 0.9TODO:
See also #421