improve readability of make_clean_names #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to make some small adjustments to the make_clean_names() function. I think these might make it more easy to reason about current and further upcoming issues in the future. The adjustments include * Some smaller adjustments in the beginning (explicit comments and removing of the pipe) * Including arguments of to_any_case() explicitly in the source code. This might make it easier to reason about issues, which might get solved by providing snakecase arguments to janitor users.
Changed `to_any_case()` to `snakecase::to_any_case()`
This was referenced Mar 4, 2020
Merged
|
@Tazinho: the overhaul of Want to take a look at #340 as it stands and, if it looks like it covers what you have here, close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to make some small adjustments regarding the readability of the
make_clean_names()function. I think these might make it more easy to reason about current and further upcoming issues. The adjustments include:to_any_case()explicitly in the source code. This might make it easier to reason about issues, which might get solved by providing snakecase arguments to janitor users.