Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH48 #199

Merged
merged 8 commits into from
Jul 8, 2024
Merged

AUTH48 #199

merged 8 commits into from
Jul 8, 2024

Conversation

bifurcation
Copy link
Collaborator

This PR contains the RFC Editor's markdown as an initial commit. The author team will review this PR as with any other changes, and make any responses to the RFC Editor as comments or further commits on this PR.

Once this PR is merged, we will indicate to the RFC Editor that the Markdown is approved for publication.

@bifurcation bifurcation requested a review from juberti as a code owner June 24, 2024 22:37
Copy link
Collaborator Author

@bifurcation bifurcation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my initial review of the RFC Editor's changes. Mostly minor stuff, a few rewordings, no major disagreements. I have made TODO(RLB) notations for things that couldn't be handled in GitHub suggestions, and will come back to implement those shortly.

draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
Comment on lines 80 to 85
<!--[rfced] May we make the title more descriptive? We note that a web search on "SFrame" returns pages describing different technologies.

Current: Secure Frame (SFrame)

Perhaps: Secure Frame (SFrame): an Encryption and Authentication Mechanism for Media Frames
-->
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to add a colon-subtitle, I would use something like:

Secure Frame (SFrame): Lightweight Authenticated Encryption for Real-Time Media

@eomara @juberti @murillo128 @youennf What do you think?

draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown edits FTW.

draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
draft-ietf-sframe-enc.md Outdated Show resolved Hide resolved
@bifurcation
Copy link
Collaborator Author

Latest commit addresses comments from @martinthomson, including reworking the audio frame table, removing inc: entries from authors and contributors and adding proper accents for @FredericJacobs.

Copy link
Collaborator

@juberti juberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read over all the changes and overall the edits all look great, the text is clear and easy to follow. Noted a couple minor nits.

4. Independence from the underlying transport, including use in non-RTP
transports, e.g., WebTransport {{?I-D.ietf-webtrans-overview}}.
4. Decouple the media encryption framework from the underlying transport,
allowing use in non-RTP, e.g., WebTransport
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
allowing use in non-RTP, e.g., WebTransport
allowing use in non-RTP transports, e.g., WebTransport

@@ -391,7 +414,7 @@ aspects of the AEAD and the hash algorithm below:
size of a "tag" that is added to the plaintext)

* `AEAD.Nka` - For cipher suites using the compound AEAD described in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally read Nka as "size-of-key-for-AEAD", which made sense to me, but then I realized that since we're always using AEAD, it's really "size-of-key-for-compound-AEAD". Maybe Nkc?

policies, that new key frame could take some time to be generated.

If the sender sends a key frame after the new E2EE key is in use, the time
required for the new participant to display the video is minimized.

Note that this issue does not arise for media streams that do not have
dependencies among frames, e.g., audio streams. In these streams, each frame is
independently decodeable, so there is never a need to process two frames
together which might be on two sides of a key rotation.
independently decodable, so there is never a need to process together two frames
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I preferred the previous text, or perhaps "process two frames together that are on either side of a key rotation".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a better rewording.

3.3.2 of ?RFC3711}} specifies a counter-based anti-replay mitigation, which
could be adapted to use with SFrame, using the CTR field as the counter.

## Metadata

The `metadata` input to SFrame operations is pure application-specified data. As
such, it is up to the application to define what information should go in the
The `metadata` input to SFrame operations an opaque byte string specified by the application. As
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `metadata` input to SFrame operations an opaque byte string specified by the application. As
The `metadata` input to SFrame operations is an opaque byte string specified by the application. As

Copy link
Collaborator

@murillo128 murillo128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although i think that we are still inconsistently using Key Id an KID and Counter and CTR. We also use Counter (CTR) in several places.

I think we should either introduce the terms once and then use the abbreviations everywhere, or not use the abbreviations at all.

@eomara eomara merged commit 8e2c739 into main Jul 8, 2024
2 checks passed
@juberti
Copy link
Collaborator

juberti commented Jul 8, 2024

@eomara did you mean to merge this? There are still outstanding discussions.

@bifurcation
Copy link
Collaborator Author

Agree that this should not have been merged quite yet. I'll start up a new PR to handle the remaining comments.

@bifurcation bifurcation mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants