Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rewards #289

Merged
merged 288 commits into from
Dec 7, 2023
Merged

Feature/rewards #289

merged 288 commits into from
Dec 7, 2023

Conversation

P-U-D-G-E
Copy link
Collaborator

Description


Type of change

Please check the options that are relevant. This PR introduces

  • Patch: Bug fix (non-breaking change which fixes an existing issue)
  • Minor: New feature (non-breaking change which adds new functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Features Description

  • NA

Test Cases

  • NA

Documentation


Checklist:

  • I have added change type (major|minor|patch) in the PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

scorpioborn and others added 25 commits November 17, 2023 11:26
Feature / Deposit amount fee message event
Feat / Subaccount and  Main account consolidated wager
Refactor / Move sub account deduction props to ticket
Fix / `subaccount` withdraw locked balances
Audit/ Rewards handler and codec fixs
Feature/rewards Merge with Master
@codecov-commenter
Copy link

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (5764801) 13.73% compared to head (f6a6113) 11.83%.

Files Patch % Lines
x/house/keeper/msg_server_withdraw.go 75.00% 6 Missing and 1 partial ⚠️
x/house/keeper/msg_server_deposit.go 81.81% 2 Missing and 2 partials ⚠️
x/house/types/deposit_authorizaton.go 20.00% 4 Missing ⚠️
x/house/types/withdraw_authorizaton.go 20.00% 4 Missing ⚠️
x/market/types/ticket.go 84.21% 3 Missing ⚠️
x/orderbook/keeper/bet_settle.go 0.00% 3 Missing ⚠️
x/bet/types/odds_type.go 66.66% 2 Missing ⚠️
x/orderbook/keeper/bet_wager.go 33.33% 2 Missing ⚠️
testutil/simapp/simapp.go 66.66% 1 Missing ⚠️
x/bet/handler.go 0.00% 1 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   13.73%   11.83%   -1.90%     
==========================================
  Files         272      346      +74     
  Lines       32460    44417   +11957     
==========================================
+ Hits         4458     5257     +799     
- Misses      27610    38679   +11069     
- Partials      392      481      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@3eyedraga 3eyedraga merged commit 87db989 into master Dec 7, 2023
22 checks passed
@3eyedraga 3eyedraga deleted the feature/rewards branch December 7, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants