Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toast add missing text color class #1162

Merged
merged 3 commits into from
Aug 17, 2023
Merged

fix: toast add missing text color class #1162

merged 3 commits into from
Aug 17, 2023

Conversation

1danii
Copy link
Contributor

@1danii 1danii commented Aug 9, 2023

Should fix #1121 when using dark mode without CSS variables

@vercel
Copy link

vercel bot commented Aug 9, 2023

@1danii is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@dan5py dan5py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1danii, thanks for the PR. You forgot to build the registry.
You need to run:

pnpm build:registry

@1danii
Copy link
Contributor Author

1danii commented Aug 12, 2023

Thanks for the correction, but when I run the script it changes all the files in the registry. Am I doing something wrong? @dan5py
image

@dan5py
Copy link
Contributor

dan5py commented Aug 12, 2023

@1danii I assume you're on Windows, right? If that's the case, Windows uses CRLF for line endings and that results in differences when JSON.stringify is used.

@shadcn I think we should add .replace(/\\r/g, "") to the JSON.stringify here:

fs.writeFileSync(
path.join(targetPath, `${item.name}.json`),
JSON.stringify(payload, null, 2),
"utf8"
)

For now @1danii, add the code I suggested up here, build the registry and then remove it before committing again. The files should still be visible as modified but once you git-add them they should disappear from staging.

@1danii
Copy link
Contributor Author

1danii commented Aug 12, 2023

@dan5py Yes the issue was only on windows, switching os fixed it, thanks for the fix!

@1danii 1danii requested a review from dan5py August 12, 2023 14:30
Copy link
Contributor

@dan5py dan5py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 11:10am

@shadcn shadcn merged commit 33b77e2 into shadcn-ui:main Aug 17, 2023
4 checks passed
@shadcn shadcn added bug Something isn't working component: toast labels Aug 17, 2023
lloydrichards pushed a commit to lloydrichards/shadcn-ui that referenced this pull request Oct 3, 2023
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: toast
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: title/description of toast hardly visible in darkmode
3 participants