-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: toast add missing text color class #1162
Conversation
@1danii is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @1danii, thanks for the PR. You forgot to build the registry.
You need to run:
pnpm build:registry
Thanks for the correction, but when I run the script it changes all the files in the registry. Am I doing something wrong? @dan5py |
@1danii I assume you're on Windows, right? If that's the case, Windows uses CRLF for line endings and that results in differences when @shadcn I think we should add ui/apps/www/scripts/build-registry.ts Lines 104 to 108 in 3c9f7ca
For now @1danii, add the code I suggested up here, build the registry and then remove it before committing again. The files should still be visible as modified but once you git-add them they should disappear from staging. |
@dan5py Yes the issue was only on windows, switching os fixed it, thanks for the fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: shadcn <[email protected]>
Co-authored-by: shadcn <[email protected]>
Should fix #1121 when using dark mode without CSS variables