Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scroll-area): Horizontal scrollbar thumb grow #1296

Merged

Conversation

SoyDiego
Copy link
Contributor

Fix #1276

CURRENT BEHAVIOUR

problem

AFTER SOLUTION

fixed

@vercel
Copy link

vercel bot commented Aug 20, 2023

@SoyDiego is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@SoyDiego
Copy link
Contributor Author

@shadcn could you check this PR?
It's about one month ago and is easy to check it.

Thanks!

@vercel
Copy link

vercel bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 4:19am

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadcn shadcn merged commit 1f16cf4 into shadcn-ui:main Sep 25, 2023
5 checks passed
@SoyDiego SoyDiego deleted the 1276-fix-horizontal-scrollbar-scroll-area branch September 25, 2023 12:14
lloydrichards pushed a commit to lloydrichards/shadcn-ui that referenced this pull request Oct 3, 2023
kodiakhq bot pushed a commit that referenced this pull request Nov 12, 2023
PRs #1515 and #1296 interfere with each other and cause the horizontal scroll bar to not be visible. This removes the conditional `flex-1`, however you could also remove `flex-col` to achieve the same result.

before:

https://github.com/shadcn-ui/ui/assets/9381099/6514de2e-e353-4d0b-bd24-aff79e0d5161

after:


https://github.com/shadcn-ui/ui/assets/9381099/3205baad-569b-4096-8dcd-9beb794de536
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
PRs shadcn-ui#1515 and shadcn-ui#1296 interfere with each other and cause the horizontal scroll bar to not be visible. This removes the conditional `flex-1`, however you could also remove `flex-col` to achieve the same result.

before:

https://github.com/shadcn-ui/ui/assets/9381099/6514de2e-e353-4d0b-bd24-aff79e0d5161

after:


https://github.com/shadcn-ui/ui/assets/9381099/3205baad-569b-4096-8dcd-9beb794de536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal Scrollbar Thumb Grow
2 participants