Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create-account.tsx #1473

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

giteshsarvaiya
Copy link

The Layout of the Create Account Card is kind of jumbled
Screenshot_20230908_012348_Chrome
I have Changed and sorted it.

Changed the layout of Create-Account Card
@vercel
Copy link

vercel bot commented Sep 7, 2023

@giteshsarvaiya is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@jocarrd
Copy link

jocarrd commented Sep 12, 2023

Nice work. It would be nice to simplify the review, a screenshot of the final result

@shadcn
Copy link
Collaborator

shadcn commented Sep 18, 2023

@giteshsarvaiya Can you attach a before and after so that I can review? I'm not sure what was fixed. Thank you.

again edited the create account form for a new layout.
@giteshsarvaiya
Copy link
Author

giteshsarvaiya commented Sep 23, 2023

sure, here is the before-after comparison:

Before:
266429450-e1d3b893-cbe3-43c1-b074-cf242821d3f4

After:
after

@shadcn
Copy link
Collaborator

shadcn commented Oct 3, 2023

@giteshsarvaiya the after screenshot looks broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants