feat(components): toggle-group #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxwiseman is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
- Dark mode border color is now consistent with the toggle component
- Added the content field to `components.json` for toggle-group - Ran build:registry again
|
@shadcn Any updates on whether or not this is going to be merged? |
|
@maxwiseman Looking into it. Note: we have 3 other PRs that also implement the toggle group components: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shadcn
added
the
area: roadmap
Closed
shadcn
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
@maxwiseman I've simplify the implementation a bit and reused the styles from toggle. Thanks for your help on this! Appreciate it!
This was referenced Nov 12, 2023
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
* feat: added toggle-group component * fix(components): ran build:registry script * fix(components): fixed colors in toggle-group - Dark mode border color is now consistent with the toggle component * fix(components): fixed component.json toggle-group - Added the content field to `components.json` for toggle-group - Ran build:registry again * feat(toggle-group): simplify implementation --------- Co-authored-by: shadcn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toggle-group
Preview
This PR adds the toggle-group primitive from Radix.
Similar to #53 and #610, but with the styling from the existing toggle component.