-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Redundant md:w-full class in DialogPrimitive.Content in dialog and alert-dialog #1640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@shiroyasha9 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
shiroyasha9
changed the title
fix(alert-dialog): remove redundant md:w-full from content
Remove Redundant md:w-full class in DialogPrimitive.Content in dialog and alert-dialog
Sep 30, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shadcn
added
bug
Something isn't working
component: alert dialog
component: dialog
area: roadmap
This looks great. We'll add it to the roadmap, review and merge.
labels
Oct 21, 2023
shadcn
approved these changes
Oct 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Thank you.
# Conflicts: # apps/www/public/registry/styles/default/alert-dialog.json # apps/www/public/registry/styles/default/dialog.json # apps/www/public/registry/styles/default/scroll-area.json # apps/www/public/registry/styles/default/sheet.json # apps/www/public/registry/styles/default/table.json # apps/www/public/registry/styles/new-york/alert-dialog.json # apps/www/public/registry/styles/new-york/dialog.json # apps/www/public/registry/styles/new-york/scroll-area.json # apps/www/public/registry/styles/new-york/sheet.json # apps/www/public/registry/styles/new-york/table.json
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
… and alert-dialog (shadcn-ui#1640) closes shadcn-ui#1639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: roadmap
This looks great. We'll add it to the roadmap, review and merge.
automerge
bug
Something isn't working
component: alert dialog
component: dialog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1639