Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add position relative to table element #428

Closed
wants to merge 9 commits into from
Closed

add position relative to table element #428

wants to merge 9 commits into from

Conversation

PixeledCode
Copy link
Contributor

closes #416

@vercel
Copy link

vercel bot commented May 23, 2023

@PixeledCode is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@PixeledCode PixeledCode mentioned this pull request May 23, 2023
Closed
its-monotype
its-monotype reviewed May 23, 2023
View reviewed changes
apps/www/components/ui/table.tsx Outdated Show resolved Hide resolved
apps/www/components/ui/table.tsx Outdated Show resolved Hide resolved
@PixeledCode @its-monotype
Update apps/www/components/ui/table.tsx
914e960 
moving position relative to scrolling wrapper

Co-authored-by: Pablo <[email protected]>
@vercel
Copy link

vercel bot commented May 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 9:29am
ui ❌ Failed (Inspect) May 30, 2023 9:29am

@PixeledCode
Copy link
Contributor Author

@its-monotype is the PR okay now?

@PixeledCode
Copy link
Contributor Author

@shadcn looks like the linting check failed because of tailwind classes order. I was not able to find a list on where to place the position class. Any suggestions?

@moreei
Copy link

moreei commented May 30, 2023

My plugin autocorrected the order to this:

<div className="relative w-full overflow-auto">

@PixeledCode
Copy link
Contributor Author

@shadcn I think it should be mergeable now

@kyb3r
Copy link

kyb3r commented Aug 26, 2023

Thanks for the fix, I was struggling with this in my app.

But how did you know what to do. Amazing.

@PixeledCode PixeledCode mentioned this pull request Aug 28, 2023
Merged
@PixeledCode
Copy link
Contributor Author

opened new issue #1370

@PixeledCode PixeledCode deleted the fix-table-overflow branch August 28, 2023 05:21
u007 pushed a commit to u007/ui that referenced this pull request Sep 1, 2024
@zernonia
feat: Blocks (shadcn-ui#428)
a03bace 
* chore: build registry

* feat: block preview

* refactor: change to use iframe
feat: add more blocks

* chore: fix build

* feat: add all other blocks

* feat: add copy button

* chore: cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@its-monotype its-monotype its-monotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behavior on table horizontal scrolling
5 participants
@PixeledCode @moreei @kyb3r @its-monotype @shadcn