-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(shadcn) arrays and nested deeply nested spread #5711
Conversation
…r' into fix-shadcn-arrays-and-spread
@bcorbold is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top-notch contribution. Really appreciate this @bcorbold
Is this released as just ran into this issue (temporarily deleting the typography part of my tailwind.config.js fixed it) |
* fix: tailwind config updater parser * fix: remove quote around spread element * fix: specify deepmerge option for array * fix(shadcn): Nested and spread array elements * add test case for boolean primitive --------- Co-authored-by: matsuyoshi30 <[email protected]> Co-authored-by: shadcn <[email protected]>
Description
Fixed
parseObjectLiteral
utilities to account for arrays and deeply nested values, and ensure that spread operators are preserved regardless of the levelBranched from #5587 for the initial fix, added additional for nested support
Example
Input
Before
After
Fixes
#4796, #4707, #4717, #4956, #4841, #4675