fix: add max height to SelectContent when position is popper #5713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctContent when position is popper. Without this, selects with many items render off screen and can't be scrolled.
|
@Tofugrass is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
max-h-[var(--radix-select-content-available-height)]to SelectContent className when position is popper according to https://www.radix-ui.com/primitives/docs/components/select#constrain-the-content-size.Without this, Select's with many items have a height greater than the screen and can't be scrolled. Tested on chrome (mobile and desktop). Tested with small lists and lists that overflow the screen. I suspect people are fixing this issue in the wild by changing position to 'item-aligned'. Radix also recommends setting the width of the SelectContent to
var(--radix-select-trigger-width);but I haven't personally had a need for this.Without max height:
With max height:
