Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples): correct placement of login button on Authentication Example for medium size page #5816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djimmo
Copy link

@djimmo djimmo commented Nov 13, 2024

For medium size pages there is a max-width for the container, causing the UI to be left aligned. Making sure the container width stays maximum fixes this problem

For medium size pages there is a max-width for the container, causing the UI to be left aligned. Making sure the container width stays maximum fixes this problem
Copy link

vercel bot commented Nov 13, 2024

@djimmo is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@djimmo djimmo changed the title correct placement of login button correct placement of login button on Authentication Example for medium size page Nov 13, 2024
@djimmo djimmo changed the title correct placement of login button on Authentication Example for medium size page fix(examples) correct placement of login button on Authentication Example for medium size page Nov 13, 2024
@djimmo djimmo changed the title fix(examples) correct placement of login button on Authentication Example for medium size page fix(examples): correct placement of login button on Authentication Example for medium size page Nov 13, 2024
@@ -30,7 +30,7 @@ export default function AuthenticationPage() {
className="hidden dark:block"
/>
</div>
<div className="container relative hidden h-[800px] flex-col items-center justify-center md:grid lg:max-w-none lg:grid-cols-2 lg:px-0">
<div className="container relative hidden h-[800px] flex-col items-center justify-center md:grid md:max-w-none lg:max-w-none lg:grid-cols-2 lg:px-0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove lg:max-w-none since screens are mobile first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants