Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code diff display in dropdown-menu documentation #5926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

terrence-ou
Copy link

Hi,

While reading the documentation for the Dropdown Menu component, I noticed some syntax highlighting issues in the changelog section that might be a bit confusing :

The code blocks in the section are visually inconsistent. One block is missing the “+” sign to emphasize the added code, another block uses tsx syntax highlighting, which doesn’t align with the purpose of the section that suggests developers to add additional tailwind styles.

To address these issues, I made the following changes:

  • Updated both code blocks in the section with diff syntax highlighting for code display consistency.
  • Added “+” signs to emphasize changes.
  • Replaced the cva reference in the second paragraph of the 2024-10-25... changelog with cn. The cva function seems not used in the associated code block, but cn is.

Please refer to the following screenshots for the changes I made on the doc, with left one is before change, and the right one is after change:

before after

Thanks for considering my PR, and please let me know if you have any feedback or additional suggestions!

Copy link

vercel bot commented Nov 24, 2024

@terrence-ou is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant