Skip to content

Commit

Permalink
fix(i): Change detector missing deps (sourcenetwork#1899)
Browse files Browse the repository at this point in the history
## Relevant issue(s)

N/A

## Description

This PR fixes an issue where the change detector was not installing
dependencies when using a local target branch.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

CI

Specify the platform(s) on which this was tested:
- MacOS
  • Loading branch information
nasdf authored Sep 20, 2023
1 parent 26e1209 commit 5aaba43
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tests/change_detector/change_detector_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import (
func TestChanges(t *testing.T) {
sourceRepoDir := t.TempDir()
execClone(t, sourceRepoDir, Repository, SourceBranch)
execMakeDeps(t, sourceRepoDir)

var targetRepoDir string
if TargetBranch == "" {
Expand All @@ -40,13 +39,15 @@ func TestChanges(t *testing.T) {
// check out the target branch
targetRepoDir = t.TempDir()
execClone(t, targetRepoDir, Repository, TargetBranch)
execMakeDeps(t, targetRepoDir)
}

if checkIfDatabaseFormatChangesAreDocumented(t, sourceRepoDir, targetRepoDir) {
t.Skip("skipping test with documented database format changes")
}

execMakeDeps(t, sourceRepoDir)
execMakeDeps(t, targetRepoDir)

targetRepoTestDir := filepath.Join(targetRepoDir, "tests", "integration")
targetRepoPkgList := execList(t, targetRepoTestDir)

Expand Down

0 comments on commit 5aaba43

Please sign in to comment.