Review fixes

1. Replace `-` with `_` for inputs 2. Rename rspec-specific-tests to rspec-specific
shakacode · Jul 23, 2024 · d9b0319 · d9b0319
1 parent 3df9da9
commit d9b0319
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 18 deletions.
diff --git a/.github/workflows/command_docs.yml b/.github/workflows/command_docs.yml
@@ -16,7 +16,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: "3.2"
+          ruby_version: "3.2"
           bundler-cache: true
       - name: Install dependencies
         run: bundle install

diff --git a/.github/workflows/rspec-shared.yml b/.github/workflows/rspec-shared.yml
@@ -3,13 +3,13 @@ name: RSpec Shared
 on:
   workflow_call:
     inputs:
-      os-version:
+      os_version:
         required: true
         type: string
-      ruby-version:
+      ruby_version:
         required: true
         type: string
-      test-tag:
+      test_tag:
         required: false
         type: string
       spec_paths:
@@ -18,7 +18,7 @@ on:
 
 jobs:
   rspec:
-    runs-on: ${{ inputs.os-version }}
+    runs-on: ${{ inputs.os_version }}
     env:
       RAILS_ENV: test
       # We have to add "_CI" to the end, otherwise it messes with tests where we switch profiles,
@@ -31,7 +31,7 @@ jobs:
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: ${{ inputs.ruby-version }}
+          ruby_version: ${{ inputs.ruby_version }}
           bundler-cache: true
       - name: Install dependencies
         run: bundle install
@@ -44,16 +44,16 @@ jobs:
           cpln profile create default --token $CPLN_TOKEN_CI --org $CPLN_ORG
           cpln image docker-login
       - name: Run tests
-        run: bundle exec rspec --format documentation ${{ inputs.test-tag && format('--tag {0}', inputs.test-tag) }} ${{ inputs.spec_paths }}
+        run: bundle exec rspec --format documentation ${{ inputs.test_tag && format('--tag {0}', inputs.test_tag) }} ${{ inputs.spec_paths }}
       - name: Upload spec log
         uses: actions/upload-artifact@master
         if: always()
         with:
-          name: spec-${{ inputs.test-tag }}-${{ github.run_id }}-${{ inputs.os-version }}-${{ inputs.ruby-version }}.log
+          name: spec-${{ inputs.test_tag }}-${{ github.run_id }}-${{ inputs.os_version }}-${{ inputs.ruby_version }}.log
           path: spec.log
       - name: Upload coverage results
         uses: actions/upload-artifact@master
         if: always()
         with:
-          name: coverage-report-${{ inputs.test-tag }}-${{ github.run_id }}-${{ inputs.os-version }}-${{ inputs.ruby-version }}
+          name: coverage-report-${{ inputs.test_tag }}-${{ github.run_id }}-${{ inputs.os_version }}-${{ inputs.ruby_version }}
           path: coverage
diff --git a/.github/workflows/rspec-specific.yml b/.github/workflows/rspec-specific.yml
@@ -8,11 +8,11 @@ on:
         required: true
 
 jobs:
-  rspec-specific-tests:
+  rspec-specific:
     name: RSpec (Specific)
     uses: ./.github/workflows/rspec-shared.yml
     with:
-      os-version: ubuntu-latest
-      ruby-version: "3.2"
+      os_version: ubuntu-latest
+      ruby_version: "3.2"
       spec_paths: ${{ inputs.spec_paths }}
     secrets: inherit
diff --git a/.github/workflows/rspec.yml b/.github/workflows/rspec.yml
@@ -12,17 +12,17 @@ jobs:
     name: RSpec (Fast)
     uses: ./.github/workflows/rspec-shared.yml
     with:
-      os-version: ubuntu-latest
-      ruby-version: "3.2"
-      test-tag: ~slow
+      os_version: ubuntu-latest
+      ruby_version: "3.2"
+      test_tag: ~slow
     secrets: inherit
 
   rspec-slow:
     name: RSpec (Slow)
     uses: ./.github/workflows/rspec-shared.yml
     if: github.event_name == 'workflow_dispatch'
     with:
-      os-version: ubuntu-latest
-      ruby-version: "3.2"
-      test-tag: slow
+      os_version: ubuntu-latest
+      ruby_version: "3.2"
+      test_tag: slow
     secrets: inherit