Fix macos build and support multiple files #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conversion of template yaml to hash and back resulted in the loss of multiple documents in one yaml file. MacOS builds require specification of the platform.
README.md
Outdated
| # Run database migrations (or other release tasks) with latest image, | ||
| # while app is still running on previous image. | ||
| # This is analogous to the release phase. | ||
| cpl runner rails db:migrate -a tutorial-app --image latest |
There was a problem hiding this comment.
We renamed the runner command to run:detached.
There was a problem hiding this comment.
yes -- that needs to be fixed in the RWRT project as well @ahangarha
There was a problem hiding this comment.
btw, should the command always be run detached? @dzirtusss ?
|
@rafaelgomesxyz ready to merge? |
From my side, yes. |
|
thank you @rafaelgomesxyz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion of template yaml to hash and back resulted in the loss of multiple documents in one yaml file.
MacOS builds require specification of the platform.