Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCR use_cassette middleware #167
base: master
Are you sure you want to change the base?
VCR use_cassette middleware #167
Changes from 17 commits
9be1949
074c3d0
d86a07c
8ea89ec
23cef9f
111630a
308eddd
97b375b
ea4dd32
09bc072
0ce2cb6
b1f96d7
7cfeae1
42b941c
616cdb4
916ad59
218e3a4
bd1dc92
b5e5202
bacf5c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use appropriate HTTP status code for server errors
In the rescue clauses of
handle_insert
andhandle_eject
,501 Not Implemented
is used to indicate errors caused byLoadError
orArgumentError
. The501
status code implies that the server does not support the functionality required to fulfill the request, which may not accurately represent these error cases. Consider using500 Internal Server Error
to represent unexpected server errors more appropriately.Apply this diff to correct the status code:
Also applies to: 59-61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grantspeelman Glad you agree!
(^・ω・^)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround to skip behavior if VCR is already in use (rspec, for example)
This file was deleted.