ci: add workaround for failing CI on Windows #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
windows-ci-workaround
branch
from
ee961ef to
60761bb
Compare
|
Hmmm. For some reason, lowering the version to 3.3.0 on Windows does not help here 🤔 It's a bit strange since in another project, that actually made the CI pass again. I will investigate why that might be the case. |
|
Yep thanks, I've seen weird behaviour like this before over the years, usually more in browser tests, sometimes it just seems to go away, also in one instance upgrading to the latest version of the test package cleared the hang. |
JKRhb
force-pushed
the
windows-ci-workaround
branch
from
60761bb to
44fffb6
Compare
|
Sorry, I realized only now that there was an essential line missing for this workaround to actually work 🤦 Now this PR should be ready for merging :) |
|
Thanks, package re released at version 9.0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #189, there is currently an issue with the CI when it is running under Dart 3.4.0 and Windows. This issue adds a workaround that lets the CI fall back to 3.3.0 under Windows so that the respective job does not fail anymore due to a timeout. As soon as the issue has been fixed upstream, this change can be reverted.