fix: accounts/accounts metadata mismatch

[gomesalexandre]

Description

Fixes a bug introduced in #5693 which fixed a regression introduced in #5693 but brought a smolish mismatch 🤯

tl;dr:

• the accounts metadata now has too many accounts, including for accounts without Tx history
• the accounts slice however, has just the right amount of accounts. This results in this guy never returning anything else than loading:

web/src/state/slices/portfolioSlice/selectors.ts

Lines 137 to 143 in 4a36aa5

	export const selectPortfolioLoadingStatus = createSelector(
	selectPortfolioLoadingStatusGranular,
	(portfolioLoadingStatusGranular): PortfolioLoadingStatus => {
	const vals = values(portfolioLoadingStatusGranular)
	if (vals.some(val => val === 'loading')) return 'loading'
	if (vals.some(val => val === 'error')) return 'error'
	return 'success'

This is explained by l.130 here:

web/src/state/slices/portfolioSlice/selectors.ts

Lines 123 to 130 in 4a36aa5

	export const selectPortfolioLoadingStatusGranular = createDeepEqualOutputSelector(
	selectPortfolioAccountMetadata,
	selectPortfolioAccounts,
	(accountMetadata, accountsById): PortfolioLoadingStatusGranular => {
	const requestedAccountIds = keys(accountMetadata)
	return requestedAccountIds.reduce<PortfolioLoadingStatusGranular>((acc, accountId) => {
	const account = accountsById[accountId]
	const accountStatus = account ? (account.assetIds.length ? 'success' : 'error') : 'loading'

Given we react on a different accountsById and accountMetadata set, the account will always be undefined - as it should - for accounts without history, but the metadata will be wrongly defined, resulting in the portfolio state being set as loading.

This introduces a bunch of bugs, mostly related to the now lack of reactivity in <AppContext />: since we're always in a portfolioLoading state, we never run the effects related to e.g fetching DeFi meta/user/data.

While this bug may be invisible when clearing the cache (there will be one render where the portfolio state is indeed "success"), having existing accounts and refreshing the app will make it obvious these effects are never ran, and DeFi data isn't fetched.

Pull Request Type

• 🐛 Bug fix (Non-breaking Change: Fixes an issue)
• 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
• 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #5692

Risk

• Accounts may be borked, test accordingly

Testing

• Demo wallet is still happy
• DeFi data is still displayed
• Accounts 0+ are still properly fetched when using native/KK
• The number of accounts for other EVM chains isn't inherited from the Ethereum account

Engineering

• ☝🏽
• Run a breakpoint in portfolioLoadingStatus in <AppContext /> and ensure we continue the execution after it

Operations

• ☝🏽

Screenshots (if applicable)

Account with DeFi position

• Prod without a cache clear

• Prod after a cache clear

• This diff

Accounts

• Prod

• This diff

Portfolio loading status

Other EVM accounts do not inherit the number of Ethereum accounts

[gomesalexandre]

Current dependencies on/for this PR:

• develop
  • PR fix: accounts/accounts metadata mismatch #5695 👈
    • PR fix: savers fromAddress account type reactivity #5696

This stack of pull requests is managed by Graphite.