Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable fiat ramp address copy for utxos #7688

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

NeOMakinG
Copy link
Collaborator

Description

The Fiat Ramp feature was including a field to copy the destination address, but we can't do this for UTXOs, cf #7663 (comment)

I disabled it for any UTXO accounts

Issue (if applicable)

N/A

Risk

Low

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Testing

  • Go to fiat ramp
  • Select an UTXO asset such as BTC or DOGE, the copy button should not be visible
  • Select any other assets of different chain types, the copy button should be visible

Engineering

n/a

Operations

n/a

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

Polygon
image

Ethereum
image

BTC
image

DOGE
image

@NeOMakinG NeOMakinG requested a review from a team as a code owner September 4, 2024 08:10
Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comment

Copy link
Contributor

@gomesalexandre gomesalexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested locally, confirmed this does what it says on the box!

https://jam.dev/c/ba6d445b-d5bb-4b59-935a-d831f74a22e0

@gomesalexandre gomesalexandre enabled auto-merge (squash) September 4, 2024 15:52
@gomesalexandre gomesalexandre merged commit 86df0f4 into develop Sep 4, 2024
3 checks passed
@gomesalexandre gomesalexandre deleted the remove-from-address-fiatramp branch September 4, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants